ci: add example notebooks server images publish workflows #640
Conversation
…b Action to kubeflow/notebooks - notebooks-v1 branch Signed-off-by: Liav Weiss (EXT-Nokia) <[email protected]>
liavweiss
force-pushed
the
migrate/example_notebook_servers_publish
branch
from
3178942 to
823e1db
Compare
|
/ok-to-test |
andyatmiami
left a comment
andyatmiami
left a comment
There was a problem hiding this comment.
Thanks for getting this PR opened up and performing validations on your end @liavweiss . Workflow files included are properly customized for kubeflow/notebooks while also preserving the original logic present in kubeflow/kubeflow.
I can happily confirm I am able to replicate this success on my own fork:
Please note I did add a commit to my fork to ensure I was not publishing packages to kubeflow org
With that change - all images were rebuilt on a VERSION change and appear listed under my Packages in GitHub:
thesuperzapper
changed the title
|
Let's wait for other publish/release workflows to be ready before merging this to avoid potentially releasing new version tags on the notebook servers before we are ready. I have created the build cache image /hold |
|
/unhold |
|
Thanks @liavweiss and @andyatmiami |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: thesuperzapper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
github-project-automation
bot
moved this from Needs Triage
to Done
in Kubeflow Notebooks
3 participants
Summary
This PR migrates the GitHub Actions workflow responsible for building and publishing all notebook server example images from the kubeflow/kubeflow repository to the kubeflow/notebooks repository.
Related: #614
Verification
Successfully built and published all notebook server example images:
https://github.com/liavweiss?tab=packages&repo_name=notebooks
I kept
ghcr.io/kubeflow/kubeflow/notebook-serversas it is, after this comment #585 (comment)